Skip to content

feat(deploy): warn when volume changes will replace machine #4726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parshnt merged 1 commit into from
Jan 21, 2026
Merged

feat(deploy): warn when volume changes will replace machine #4726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 20 additions & 9 deletions internal/command/deploy/machines.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
"github.com/superfly/flyctl/internal/flapsutil"
"github.com/superfly/flyctl/internal/flyutil"
"github.com/superfly/flyctl/internal/machine"
"github.com/superfly/flyctl/internal/prompt"
"github.com/superfly/flyctl/internal/tracing"
"github.com/superfly/flyctl/internal/uiex"
"github.com/superfly/flyctl/internal/uiexutil"
Expand Down Expand Up @@ -311,7 +312,7 @@ func NewMachineDeployment(ctx context.Context, args MachineDeploymentArgs) (_ Ma
}

// validations must happen after every else
if err := md.validateVolumeConfig(); err != nil {
if err := md.validateVolumeConfig(ctx); err != nil {
tracing.RecordError(span, err, "failed to validate volume config")
return nil, err
}
Expand Down Expand Up @@ -465,7 +466,7 @@ func (md *machineDeployment) popVolumeFor(name, region string) *fly.Volume {
return nil
}

func (md *machineDeployment) validateVolumeConfig() error {
func (md *machineDeployment) validateVolumeConfig(ctx context.Context) error {
machineGroups := lo.GroupBy(
lo.Map(md.machineSet.GetMachines(), func(lm machine.LeasableMachine, _ int) *fly.Machine {
return lm.Machine()
Expand Down Expand Up @@ -494,13 +495,23 @@ func (md *machineDeployment) validateVolumeConfig() error {
for _, m := range ms {
mConfig := m.GetConfig()
if mntDst == "" && len(mConfig.Mounts) != 0 {
// TODO: Detaching a volume from a machine is possible, but it usually means a missconfiguration.
// We should show a warning and ask the user for confirmation and let it happen instead of failing here.
return fmt.Errorf(
"machine %s [%s] has a volume mounted but app config does not specify a volume; "+
"remove the volume from the machine or add a [mounts] section to fly.toml",
m.ID, groupName,
)
msg := fmt.Sprintf("Warning! machine %s [%s] has a volume mounted but app config does not specify a volume.\nThis usually indicates a misconfiguration.", m.ID, groupName)
fmt.Fprintln(md.io.ErrOut, md.colorize.Red(msg))

switch confirmed, err := prompt.Confirm(ctx, "Do you still want to continue and detach the volume? This will replace the machine."); {
case err == nil:
if !confirmed {
return fmt.Errorf(
"deployment cancelled: machine %s [%s] has a volume mounted but app config does not specify a volume; "+
"remove the volume from the machine or add a [mounts] section to fly.toml",
m.ID, groupName,
)
}
case prompt.IsNonInteractive(err):
return prompt.NonInteractiveError("yes flag must be specified when not running interactively")
default:
return err
}
}

if mntDst != "" && len(mConfig.Mounts) == 0 {
Expand Down
1 change: 0 additions & 1 deletion internal/command/deploy/machines_launchinput.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ func (md *machineDeployment) launchInputForUpdate(origMachineRaw *fly.Machine) (
case len(mMounts) == 0:
// The mounts section was removed from fly.toml
machineShouldBeReplaced = true
terminal.Warnf("Machine %s has a volume attached but fly.toml doesn't have a [mounts] section\n", mID)
case oMounts[0].Name == "":
// It's rare but can happen, we don't know the mounted volume name
// so can't be sure it matches the mounts defined in fly.toml, in this
Expand Down
Loading