Warn about fly.toml mismatch after fly scale vm/memory#4749
Open
Warn about fly.toml mismatch after fly scale vm/memory#4749
Conversation
After a successful `fly scale vm` or `fly scale memory`, check the local fly.toml for a [[vm]] section with conflicting size or memory settings. If found, print a warning that the next `fly deploy` will override the changes. No warning when fly.toml is missing, has no [[vm]] section, or matches the scaled values.
Pull WarningIcon() out of the Yellow() wrapper to match the existing pattern in certificates/root.go. Run go fmt to fix struct field alignment in config_warning_test.go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fly scale vmorfly scale memory, checks the localfly.tomlfor a[[vm]]section with conflicting size or memory settingsfly deploywill override the scale changes[[vm]]section, or values already matchTest plan
go build ./...passesgo test ./internal/command/scale/ -v— all tests pass (7 new + existing)fly scale memory 512 -a <app>in a directory with afly.tomlthat has[[vm]]with different memory → warning appearsfly.toml→ no warningfly.tomlbut no[[vm]]section → no warning