[SuperTextField] New variations of AttributedTextEditingController.clear() (Resolves #2094) #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -803,7 +803,192 @@ void main() { | |||
| }); | |||
| }); | |||
|
|
|||
| group("clearText", () { | |||
There was a problem hiding this comment.
I think we've tried to move away from naming groups or tests after a specific method. Can you describe the group and tests in terms of regular English? That terminology can still use words like "clear" and "text" but should read as a series of words.
You can also using a trailing ">" in group names, where appropriate. If you check Super Editor, you'll see a lot of groups named like that.
| @@ -803,7 +803,192 @@ void main() { | |||
| }); | |||
| }); | |||
|
|
|||
| group("clearText", () { | |||
| test('clears the text', () { | |||
There was a problem hiding this comment.
It looks like there are separate tests from simultaneous expected conditions. There probalby isn't any reason to separate them. It looks like you should probably verify all conditions in the same test. You'll just want to make sure the test name captures the goal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Resolves #2094)