feat: multithreaded bulk import #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamassoltesz
changed the title
9 tasks
sattvikc
requested changes
Dec 9, 2024
src/main/java/io/supertokens/bulkimport/BulkImportBackgroundJobManager.java
Outdated
Show resolved
Hide resolved
src/main/java/io/supertokens/bulkimport/BulkImportBackgroundJobManager.java
Outdated
Show resolved
Hide resolved
sattvikc
requested changes
Dec 9, 2024
src/test/java/io/supertokens/test/bulkimport/apis/BulkImportBackgroundJobManagerAPITest.java
Outdated
Show resolved
Hide resolved
src/main/java/io/supertokens/webserver/api/bulkimport/BulkImportAPI.java
Show resolved
Hide resolved
src/main/java/io/supertokens/webserver/api/bulkimport/BulkImportBackgroundJobManagerAPI.java
Outdated
Show resolved
Hide resolved
src/main/java/io/supertokens/webserver/api/bulkimport/CountBulkImportUsersAPI.java
Outdated
Show resolved
Hide resolved
src/main/java/io/supertokens/webserver/api/bulkimport/ImportUserAPI.java
Outdated
Show resolved
Hide resolved
sattvikc
approved these changes
Dec 18, 2024
sattvikc
added a commit
that referenced
this pull request
Dec 19, 2024
* feat: Add BulkImport APIs and cron * chore: update pull request template * fix: Use the correct tenant config to create the proxy storage * fix: PR changes * fix: PR changes * fix: PR changes * fix: PR changes * fix: PR changes * fix: PR changes * fix: Update version * fix: PR changes * fix: PR changes * fix: Rename DeleteBulkImportUser API path * fix: disable bulk import for in-memory db * fix: a bug with createTotpDevices * fix: PR changes * feat: Add an api to import user in sync * feat: Add an api to get count of bulk import users * fix: PR changes * fix: Add error codes and plainTextPassword import * fix: PR changes * feat: multithreaded bulk import * fix: changelog update * fix: add new test * fix: fixing unreliable mutithreaded bulk import with mysql * fix: review fixes * fix: fixing failing tests * feat: bulkimport flow tests * feat: bulk import cron starter api * fix: tweaking params for faster import * fix: tests * checkpoint * fix: remove vacuuming * fix: minor tweaks * feat: bulk inserting the bulk migration data * fix: fast as a lightning * fix: restoring lost method * fix: reworked error handling to comform previous approach with messages * fix: fixing tests * fix: fixing failing tests, changing version * chore: update changelog * fix: fixing issues and failing tests * fix: review changes * fix: review fixes, reworking cron start/stop --------- Co-authored-by: Tamas Soltesz <[email protected]> Co-authored-by: Ankit Tiwari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Core implementation of Bulk User Migration.
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your
changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here
highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)pluginInterfaceSupported.jsonfile has been updated (if needed)build.gradlegetPaidFeatureStatsfunction in FeatureFlag.java filebuild.gradle, please make sure to add themin
implementationDependencies.json.getValidFieldsinio/supertokens/config/CoreConfig.javaif new aliases were added for any coreconfig (similar to the
access_token_signing_key_update_intervalconfig alias).git tag) in the formatvX.Y.Z, and then find thelatest branch (
git branch --all) whoseX.Yis greater than the latest released tag.app_id_to_user_idtable, make sure to delete from this table when deletingthe user as well if
deleteUserIdMappingToois false.Remaining TODOs for this PR