Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repeated headers/entries in access-control-expose-headers #726

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

porcellus
Copy link
Collaborator

Summary of change

  • De-duplicate entries in set headers even if allowDuplicateKey is true
  • Make sure we overwrite old cookies

Related issues

Test Plan

Added test described in slack thread (https://supertokens.slack.com/archives/C03J31QAQLC/p1697639483542429)

Documentation changes

N/A

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.

@netlify
Copy link

netlify bot commented Oct 21, 2023

Deploy Preview for precious-marshmallow-968a81 canceled.

Name Link
🔨 Latest commit c9e4154
🔍 Latest deploy log https://app.netlify.com/sites/precious-marshmallow-968a81/deploys/65340d22d9005b00081a04d1

@netlify
Copy link

netlify bot commented Oct 21, 2023

Deploy Preview for astounding-pegasus-21c111 canceled.

Name Link
🔨 Latest commit c9e4154
🔍 Latest deploy log https://app.netlify.com/sites/astounding-pegasus-21c111/deploys/65340d224af0ee0008d19956

@rishabhpoddar rishabhpoddar changed the base branch from master to 16.3 October 23, 2023 08:07
@rishabhpoddar rishabhpoddar merged commit 8ea3a39 into 16.3 Oct 23, 2023
20 of 23 checks passed
@rishabhpoddar rishabhpoddar deleted the fix/repeated_headers branch October 23, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants