Skip to content

Commit

Permalink
編集時のプレビューで”が"で表示される #52
Browse files Browse the repository at this point in the history
 コメントに何も入力しないで登録するとエラーになる #53
 コメントの順番がおかしくなることがある #54
  • Loading branch information
koda-masaru committed Jun 15, 2015
1 parent 96f99f3 commit 0e11ef7
Show file tree
Hide file tree
Showing 9 changed files with 25 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public Boundary view_edit() throws InvalidParamException {
setAttribute("edit", false);
addMsgWarn("knowledge.edit.noaccess");
//return forward("/open/knowledge/view.jsp");
return devolution(HttpMethod.get, "open.knowledge/view", String.valueOf(knowledgeId));
return devolution(HttpMethod.get, "open.Knowledge/view", String.valueOf(knowledgeId));
}

return forward("view_edit.jsp");
Expand Down Expand Up @@ -248,7 +248,7 @@ public Boundary update(KnowledgesEntity entity) throws Exception {
setAttribute("edit", false);
addMsgWarn("knowledge.edit.noaccess");
//return forward("/open/knowledge/view.jsp");
return devolution(HttpMethod.get, "open.knowledge/view", String.valueOf(entity.getKnowledgeId()));
return devolution(HttpMethod.get, "open.Knowledge/view", String.valueOf(entity.getKnowledgeId()));
}

LOG.trace("save");
Expand Down Expand Up @@ -295,7 +295,7 @@ public Boundary delete() throws Exception {
setAttribute("edit", false);
addMsgWarn("knowledge.edit.noaccess");
//return forward("/open/knowledge/view.jsp");
return devolution(HttpMethod.get, "open.knowledge/view", String.valueOf(knowledgeId));
return devolution(HttpMethod.get, "open.Knowledge/view", String.valueOf(knowledgeId));
}
LOG.trace("save");
knowledgeLogic.delete(knowledgeId, getLoginedUser());
Expand Down Expand Up @@ -328,12 +328,12 @@ public Boundary comment() throws Exception {
// 共通処理呼の表示条件の保持の呼び出し
String params = setViewParam();
Long knowledgeId = super.getPathLong(Long.valueOf(-1));
String comment = super.doSamy(getParam("comment"));
String comment = super.doSamy(getParam("addcomment"));

// 必須チェック
if (StringUtils.isEmpty(comment)) {
addMsgWarn("errors.required", "Comment");
return super.devolution(HttpMethod.get, "/open.knowledge/view/" + knowledgeId + params);
return super.devolution(HttpMethod.get, "open.Knowledge/view", String.valueOf(knowledgeId));
}
KnowledgeLogic.get().saveComment(knowledgeId, comment);
return super.redirect(getRequest().getContextPath() + "/open.knowledge/view/" + knowledgeId + params);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ public List<CommentsEntity> selectOnKnowledgeId(Long knowledgeId) {
builder.append("SELECT *, USERS.USER_NAME AS UPDATE_USER_NAME FROM COMMENTS ");
builder.append("LEFT OUTER JOIN USERS ON USERS.USER_ID = COMMENTS.UPDATE_USER ");
builder.append("WHERE KNOWLEDGE_ID = ? ");
builder.append("ORDER BY COMMENTS.INSERT_DATETIME ");
return executeQueryList(builder.toString(), CommentsEntity.class, knowledgeId);
}

Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/appresource.properties
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ message.allready.updated=Allready updated.
message.allready.started=Allready started.

# Common Label
label.version=0.5.2 pre3
label.version=0.5.2 pre4
label.login=Sign in
label.previous = Previous
label.next=Next
Expand Down
8 changes: 4 additions & 4 deletions src/main/resources/appresource_ja.properties
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ message.allready.updated=すでに更新されています
message.allready.started=すでに開始済です

# Common Label
label.version=0.5.2 pre3
label.version=0.5.2 pre4
label.login=サインイン
label.previous = 前へ
label.next = 次へ
Expand Down Expand Up @@ -112,8 +112,8 @@ knowledge.navbar.search.placeholder=キーワードで検索
knowledge.navbar.account.myaccount=自分のアカウント情報
knowledge.navbar.account.myknowledge=自分で登録したナレッジ
knowledge.navbar.account.notify=通知設定
knowledge.navbar.signin=サインインします
knowledge.navbar.signout=サインアウトします
knowledge.navbar.signin=サインイン
knowledge.navbar.signout=サインアウト
knowledge.navbar.lang=表示言語
knowledge.navbar.lang.en=English
knowledge.navbar.lang.ja=Japanese
Expand All @@ -130,7 +130,7 @@ knowledge.navbar.data.export=エクスポート

knowledge.auth.description=サインインが必要な機能です。<br/>(ナレッジの編集などはサインインが必要です)
knowledge.auth.signin=サインイン実行
knowledge.auth.signup=ユーザ未登録の人は「ユーザ新規登録」できます
knowledge.auth.signup=アカウント新規登録
knowledge.auth.forgot.password=パスワードを忘れましたか?
knowledge.auth.label.mail=メールアドレス
knowledge.auth.label.id=ID
Expand Down
4 changes: 3 additions & 1 deletion src/main/webapp/WEB-INF/views/open/knowledge/view.jsp
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ var LABEL_LIKE = '<%= jspUtil.label("knowledge.view.like") %>';

<% if (request.getRemoteUser() != null) { %>
<form action="<%= request.getContextPath()%>/protect.knowledge/comment/<%= jspUtil.out("knowledgeId") %><%= jspUtil.out("params") %>" method="post" role="form">
<textarea class="form-control" name="comment" rows="1" placeholder="Comment" id="comment"></textarea>
<textarea class="form-control" name="addcomment" rows="1" placeholder="Comment" id="comment"><%= jspUtil.out("addcomment") %></textarea>

<% if (jspUtil.out("insertUser").equals(request.getRemoteUser())) { %>
<button type="button" class="btn btn-info" onclick="previewans();"><i class="fa fa-play-circle"></i>&nbsp;<%= jspUtil.label("label.preview") %></button>
Expand All @@ -218,6 +218,8 @@ var LABEL_LIKE = '<%= jspUtil.label("knowledge.view.like") %>';


<p class="preview markdown" id="preview"></p>
<span style="display: none;" id="comment_text">
</span>


<span style="display: none;" id="content_text">
Expand Down
2 changes: 2 additions & 0 deletions src/main/webapp/WEB-INF/views/protect/knowledge/view_add.jsp
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,8 @@ selectedEditors.push({label: '<%= jspUtil.out("editor.label") %>', value: '<%= j


<p class="preview markdown" id="preview"></p>
<span style="display: none;" id="content_text">
</span>


<%-- Editors --%>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ selectedEditors.push({label: '<%= jspUtil.out("editor.label") %>', value: '<%= j
</form>

<p class="preview markdown" id="preview"></p>

<span style="display: none;" id="content_text">
</span>

<%-- Editors --%>
<div class="modal fade" id="editorSelectModal" tabindex="-1" role="dialog" aria-labelledby="editorModalLabel" aria-hidden="true">
Expand Down
4 changes: 3 additions & 1 deletion src/main/webapp/js/knowledge-edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,8 @@ var preview = function() {
title : $('#input_title').val(),
content : $('#content').val()
}, function(data) {
$('#content_text').html(data.content);

var html = '<div class="row">';
html += '<div class="col-sm-12">';
html += '<div class="thumbnail">';
Expand All @@ -306,7 +308,7 @@ var preview = function() {
html += data.title;
html += '</h3>';
html += '<p style="word-break:break-all" id="content">';
var content = marked(data.content);
var content = marked($('#content_text').html());
html += content;
html += '</p>';
html += '</div>';
Expand Down
6 changes: 4 additions & 2 deletions src/main/webapp/js/knowledge-view.js
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ var preview = function() {
title : '',
content : $('#comment').val()
}, function(data) {
$('#comment_text').html(data.content);
var html = '<div class="question_Box">';
html += '<div class="question_image">';
html += '<img src="' + _CONTEXT + '/open.account/icon/' + $('#loginuser').val() + '" ';
Expand All @@ -113,7 +114,7 @@ var preview = function() {
html += '<div class="arrow_question">';

html += '<p style="word-break:break-all" id="content">';
content = marked(data.content);
var content = marked($('#comment_text').html());
html += content;

html += '</div><!-- /.arrow_question -->';
Expand All @@ -135,6 +136,7 @@ var previewans = function() {
title : '',
content : $('#comment').val()
}, function(data) {
$('#comment_text').html(data.content);
var html = '<div class="question_Box">';
html += '<div class="answer_image">';
html += '<img src="' + _CONTEXT + '/open.account/icon/' + $('#loginuser').val() + '" ';
Expand All @@ -143,7 +145,7 @@ var previewans = function() {
html += '<div class="arrow_answer">';

html += '<p style="word-break:break-all" id="content">';
content = marked(data.content);
var content = marked($('#comment_text').html());
html += content;

html += '</div>';
Expand Down

0 comments on commit 0e11ef7

Please sign in to comment.