Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes iOS resize flicker, jQuery mobile pagechange issue, less than one column bug, and jshint #22

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

pandaiolo
Copy link

Here are the two issues fixed in this pull request, along with small fixes by jshint:

  • iOS resize event beeing fired a lot on scroll behaviour
    Grid-A-Licious would flicker / scroll to top every few seconds. I added a check on the width to trigger redraw only if the width actualy changes.
  • jQuery Mobile page transition
    width would be equal to zero upon page change in jQuery mobile, which would need to trigger Grid-A-Licious later (w/ visible flicker). Instead I changed the way width is calculated, by switching the display css value to block while getting the good value.

Notes:

  • Also included @falconwhite pull, with a Math.max instead of the if
  • Applied jshint fixes
  • minified file is up to date

(I did not included the older pull, as it's more than just bugfixing)

@connor
Copy link

connor commented Sep 28, 2013

This looks good to me! @suprb what do you think?

@someok
Copy link

someok commented Sep 29, 2014

yeah, it work fine, 3kx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants