Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add favicon #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add favicon #5

wants to merge 1 commit into from

Conversation

BravishkaSkytano
Copy link

Every site should have a favicon. Users will only need to add one file to the site's root directory.

@BravishkaSkytano BravishkaSkytano marked this pull request as ready for review November 19, 2020 02:19
@supun-io
Copy link
Owner

Apologies for the 2-year delay. This would limit the favicon to be .png, wouldn't it? I think it would be better to not have this, as all browsers default to favicon.ico. If the user needs something else, he'd add a custom line like this.

Open for feedback.

@BravishkaSkytano
Copy link
Author

It's been a while since I used this theme, however, I do recall trying to use a favicon.ico and it didn't work. You could set it as a config variable instead, I suppose.

favicon: /assets/favicon.ico
<link rel="icon" type="image/png" sizes="32x32" href="{{ site.favicon }}">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants