fix: example and vulnerabilities #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 anything I can do with to help move it along? Happy to provide some demos from my fork if it'd make you folks feel more comfortable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like running things through Gulp. This package had some vulnerabilities. Most of them were quickly fixed with
npm audit fixone of them required a manual bump to Mocha (3 major versions, but test still runs fine).I really think surge is great. Thanks for making it!
Oh I also did some modernizing mods. Arrow functions and refs to
constovervar. Made the gulpfile agree with current requirements from gulp (use exported functions instead of.task) and got the README to show an example that is in line with these suggestions from gulp.Oh and deleted a trash test.