Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimator improvements #443

Merged
merged 4 commits into from
Sep 19, 2024

Conversation

sthaha
Copy link
Contributor

@sthaha sthaha commented Sep 12, 2024

image

Checklist for PR Author


In addition to approval, the author must confirm the following check list:

  • Run the following command to format your code:

    make fmt
  • Create issues for unresolved comments and link them to this PR. Use one of the following labels:

    • must-fix: The logic appears incorrect and must be addressed.
    • minor: Typos, minor issues, or potential refactoring for better readability.
    • nit: Trivial issues like extra spaces, commas, etc.

@sthaha sthaha force-pushed the estimator-improvements branch 3 times, most recently from 5295d24 to 2c70de2 Compare September 19, 2024 00:45
@sthaha sthaha marked this pull request as ready for review September 19, 2024 04:51
Copy link
Collaborator

@KaiyiLiu1234 KaiyiLiu1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sthaha sthaha force-pushed the estimator-improvements branch from 98a31f7 to 21fe291 Compare September 19, 2024 06:50
@sthaha sthaha merged commit 1e39c25 into sustainable-computing-io:main Sep 19, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants