fix: check length of PROM_THIRDPARTY_METRICS #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sthaha
requested changes
Oct 22, 2024
There was a problem hiding this comment.
@vprashar2929 how about we fix the check (if PROM_.. ) instead of adding dummy ""
This commit updates the condition to check the length of `PROM_THIRDPARTY_METRICS` instead of comparing it to `[""]` Signed-off-by: Vibhu Prashar <[email protected]>
vprashar2929
force-pushed
the
chore-tp
branch
from
ffc2f9c
to
c6acd08
Compare
vprashar2929
changed the title
sthaha
reviewed
Oct 22, 2024
Comment on lines
+151
to
154
| elif len(PROM_THIRDPARTY_METRICS) > 0: | ||
| queries = [m for m in available_metrics if args.metric_prefix in m or m in PROM_THIRDPARTY_METRICS] | ||
| else: | ||
| queries = [m for m in available_metrics if args.metric_prefix in m] |
There was a problem hiding this comment.
is this condition needed any more since PROM_THIRD.. is a list already ?
sthaha
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the condition to check the length of
PROM_THIRDPARTY_METRICSinstead of comparing it to[""]Checklist for PR Author
In addition to approval, the author must confirm the following check list:
Run the following command to format your code:
Create issues for unresolved comments and link them to this PR. Use one of the following labels:
must-fix: The logic appears incorrect and must be addressed.minor: Typos, minor issues, or potential refactoring for better readability.nit: Trivial issues like extra spaces, commas, etc.