ci: add shellcheck linter #262
Open
+37
−223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sthaha
commented
Oct 2, 2023
•
sthaha
commented
- adds a new CI job to run shellcheck linter
- fixes shellcheck errors and removes unused scripts
Signed-off-by: Sunil Thaha <[email protected]>
|
cc: @vprashar2929 |
Signed-off-by: Sunil Thaha <[email protected]>
|
@sthaha Can you add the description for the PR?🙂 |
|
Shouldn't we add a shellcheck for source here as well? |
Somehow shellchecker is happy. It could probably be the SHELLCHECK_OPT -x that is automatically following the sourced file. |
|
Wired🤔 then why not the same for other scripts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.