Add response auditing capability to Pinot's audit logging system#2
Open
suvodeep-pyne wants to merge 5 commits intomasterfrom
Open
Add response auditing capability to Pinot's audit logging system#2suvodeep-pyne wants to merge 5 commits intomasterfrom
suvodeep-pyne wants to merge 5 commits intomasterfrom
Conversation
…esponse code logging
…esponse code logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances Pinot's audit logging system by adding response auditing capability, enabling complete request-response cycle tracking for better observability and compliance.
Changes
ContainerRequestFilterandContainerResponseFilterinterfacesKey Features
capture.response.enabledconfigFiles Modified
AuditConfig.java: Addedcapture.response.enabledconfiguration fieldAuditEvent.java: Addedrequest_id,response_code, andduration_msfields with proper JSON annotationsAuditLogFilter.java: Implemented response filter with timing and correlation logicAuditResponseContext.java: New context wrapper for passing data between filtersAuditRequestProcessor.java: Minor refactoring for consistencyConfiguration
To enable response auditing:
Sample Output
Request audit log:
{ "request_id": "550e8400-e29b-41d4-a716-446655440000", "timestamp": "2025-01-17T10:30:45.123Z", "service_id": "controller", "endpoint": "/tables/myTable", "method": "POST", "user_id": {"principal": "user@company.com"} }Response audit log:
{ "request_id": "550e8400-e29b-41d4-a716-446655440000", "timestamp": "2025-01-17T10:30:45.456Z", "endpoint": "/tables/myTable", "method": "POST", "response_code": 200, "duration_ms": 333 }Testing