Allow empty FullyCharged and DesignCapacity
#93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because these keys are empty on MacMini and MacPro. `InstantData::try_from` should not throw error on empty values.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MacMini M1(or maybe all devices with macOS 12, I haven't tested on other macs),
FullyChargedandDesignCapacityare missing.However, current both of them are required or
PowerSourcewill throw an error. SourceCode e.g. the following errorThis pr makes
PowerSourceaccepts emptyFullyChargedandDesignCapacity.If they are missing, users will get a default value. (i.e.
trueforFullyChargedandDefault::default()forDesignCapacity).