Skip to content

Conversation

@GauBen
Copy link
Contributor

@GauBen GauBen commented Mar 9, 2025

Hey!

Small Sunday evening PR to add a missing feature:

// add.js
export function add () {}

// index.js
export { add as default } from './add.js'

is now properly bundled:

export default function add () {}
export {}

I'm not sure I did everything right, but all the tests are passing, it must not be that bad

Hope you have time to review this soon :)

@changeset-bot
Copy link

changeset-bot bot commented Mar 9, 2025

🦋 Changeset detected

Latest commit: 06d0d7b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
dts-buddy Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GauBen GauBen changed the title feat: support export { ... as default} from ... feat: support export { ... as default } from ... Mar 9, 2025
@GauBen
Copy link
Contributor Author

GauBen commented Mar 9, 2025

Ok here is the fun thing: it does not even solve my problem... Back to square 1

@GauBen
Copy link
Contributor Author

GauBen commented Mar 9, 2025

Damn TypeScript API is abstruse

@Rich-Harris
Copy link
Member

Thank you! I had a hunch that this indicated an opportunity to simplify some stuff — hammered on it for a bit and opened #99 which continues this PR. Closing this in favour of that one

@Rich-Harris Rich-Harris closed this Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants