Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow embedding a sveltekit page as a widget in a third party website #13638

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

unlocomqx
Copy link

@unlocomqx unlocomqx commented Mar 25, 2025

Implements #13589

This (draft) PR brings the possibility to embed a sveltekit page as a widget in a third party website in a convenient manner.

It's just a proof-of-concept, showing how easy (or how hard) it is to implement.

How it works

Any +page.server.js can export an embed function and return an object containing a target (a dom selector)

// /routes/embed/+page.server.js
export const embed = (event) => {
  const target = event.url.searchParams.get('target');
  if (target) {
    return {
      target
    };
  }

  return null;
};

In this case, the page can be embedded by including this script

<!-- The /embed page will be embedded into section#main -->
<script defer src="http://my-app.com/embed?target=section%23main"></script>

What works

  • Server data loading and invalidation
  • SSR
  • Form actions
  • Navigation between routes (currently without the url bar reflecting the navigation)

How to test

I added a test app in kit/packages/kit/test/apps/embedded-widget

localhost_5173_third-party

Stackblitz

pnpm install
cd packages/kit/test/apps/embedded-widget/
pnpm run dev

Todo

  • Use url hashes for navigation (because we can't change the pathname of the third party app)
  • Respect browser back/forward button

Extra details

The code adds the embed script origin to the app base

The code also uses the document.currentScript.src instead of the location to determine if a url is external to the widget. There might be other places where this should be done and I've missed it.

Feel free to test, I would love to know what you think about this and if it's a good feature

Cheers


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Mar 25, 2025

⚠️ No Changeset found

Latest commit: 0440806

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link

@unlocomqx unlocomqx changed the title Embed Allow embedding a sveltekit page as a widget in a third party website Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant