Skip to content

feat: run vite preview in workerd with the Cloudflare Vite plugin - #17521

Draft
teemingc wants to merge 6 commits into
claude/cloudflare-workers-build-outputfrom
claude/cloudflare-workers-preview
Draft

teemingc wants to merge 6 commits into
claude/cloudflare-workers-build-outputfrom
claude/cloudflare-workers-preview

Conversation

@teemingc

Copy link
Copy Markdown
Member

TODO

@pkg-svelte-dev

pkg-svelte-dev Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 2dd74d5:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/2dd74d5411e87bdaa6d90e6053afc30fbcf9851a

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17521

@changeset-bot

changeset-bot Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2dd74d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/kit Minor
@sveltejs/adapter-cloudflare Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

@teemingc teemingc added needs-platform-tests This PR needs to run platform tests in order to merge. pkg:adapter-cloudflare labels Oct 22, 2026
@teemingc
teemingc force-pushed the claude/cloudflare-workers-preview branch from d7d2cec to c5dfc81 Compare October 27, 2026 14:17
@teemingc
teemingc force-pushed the claude/cloudflare-workers-preview branch from 55e1aea to 9cd2ad2 Compare October 27, 2026 14:42
Comment on lines +162 to +166
if (config.paths.assets) {
throw new Error(
'@sveltejs/adapter-cloudflare does not support paths.assets because vite preview cannot serve assets from a separate location. Remove paths.assets from your SvelteKit configuration.'
);
}

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff looks big but we're just changing it to a function which validates the svelte config. We reject paths.assets because I'm pretty sure it doesn't work today and no one uses it anyway when deploying to Cloudflare Workers?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-platform-tests This PR needs to run platform tests in order to merge. pkg:adapter-cloudflare

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant