Skip to content

chore: simplify a few server and build helpers - #17531

Open
fru1tworld wants to merge 1 commit into
sveltejs:mainfrom
fru1tworld:chore/simplify-server-utils
Open

fru1tworld wants to merge 1 commit into
sveltejs:mainfrom
fru1tworld:chore/simplify-server-utils

Conversation

@fru1tworld

@fru1tworld fru1tworld commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

A few small cleanups I noticed while reading the server runtime and build code. No behaviour changes.

  • write_parent_tsconfig passes transform to normalize_config, which already applies it, instead of applying it again itself
  • state.prerendering || state.prerender_default === true was repeated 9 times across render.js, page/index.js and load_data.js. It's now an is_prerendering(state) helper in runtime/server/utils.js
  • prerender.js uses the existing write helper from core/sync/utils.js for the two mkdirSync + writeFileSync pairs
  • the 405 response in respond.js builds its mod with Object.fromEntries instead of a reduce
  • indexOf(...) === -1 → includes(...), forEach → for...of, and redirect_response returns the Response directly

Ran pnpm -F @sveltejs/kit test:unit, pnpm -F @sveltejs/kit check, and the prerendering-test-basics suite.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from bd27137:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/bd2713747c5e49653e5c88e3cb5aa56544ce9022

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17531

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Oct 23, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: bd27137

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a patch changeset for this just so that it's easier to find in the changelog if it somehow creates any regressions.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants