Skip to content

fix(adapter-bun): allow precompress together with compile - #17541

Open
derkbell wants to merge 1 commit into
sveltejs:mainfrom
derkbell:adapter-bun-precompress-compile
Open

derkbell wants to merge 1 commit into
sveltejs:mainfrom
derkbell:adapter-bun-precompress-compile

Conversation

@derkbell

Copy link
Copy Markdown

closes #17540

precompress was ignored when buildOptions.compile was set, because only the identity file of each asset was embedded in the executable and the route served variants by appending .br/.gz to that path.

This PR embeds the .br and .gz variants too. In compiled builds, AssetMeta.br/gz now hold the embedded path of the variant instead of true, and file_route uses that path when it is a string. Non-compiled builds are unchanged. The warning is removed and the docs updated.

Note: compiled executables get larger when precompress is enabled, since variants are embedded alongside the originals.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 9c13cd6:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/9c13cd6a0a192980f4083813d15c353835b0aae1

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/17541

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Oct 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9c13cd6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-bun Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

for (const encoding of /** @type {const} */ (['br', 'gz'])) {
if (!meta[encoding]) continue;
const variant = `${file}.${encoding}`;
embedded.set(variant, `asset_${embedded.size}`);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When client output already contains a compressed variant such as app.js.gz, enabling precompress with compile can generate duplicate import identifiers and fail the executable build.

Fix on Vercel

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adapter-bun: support precompress together with buildOptions.compile

1 participant