Repository navigation
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/9c13cd6a0a192980f4083813d15c353835b0aae1Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 9c13cd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| for (const encoding of /** @type {const} */ (['br', 'gz'])) { | ||
| if (!meta[encoding]) continue; | ||
| const variant = `${file}.${encoding}`; | ||
| embedded.set(variant, `asset_${embedded.size}`); |
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #17540
precompresswas ignored whenbuildOptions.compilewas set, because only the identity file of each asset was embedded in the executable and the route served variants by appending.br/.gzto that path.This PR embeds the
.brand.gzvariants too. In compiled builds,AssetMeta.br/gznow hold the embedded path of the variant instead oftrue, andfile_routeuses that path when it is a string. Non-compiled builds are unchanged. The warning is removed and the docs updated.Note: compiled executables get larger when
precompressis enabled, since variants are embedded alongside the originals.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits