fix: disallow accessing internal Svelte props #12207
Merged
+55
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow to write `let props = $props()` - optimize read access of props.x to use `$$props` argument directly; closes #11055
🦋 Changeset detectedLatest commit: 72add9b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5 tasks
trueadm
reviewed
Jun 27, 2024
| @@ -78,6 +78,10 @@ | |||
|
|
|||
| > Cannot use `$props()` more than once | |||
| ## props_illegal_name | |||
|
|
|||
| > Declaring or accessing a property starting with `$$` is illegal (they are reserved for Svelte internals) | |||
There was a problem hiding this comment.
Should it be prop, rather than property?
There was a problem hiding this comment.
Yeah I think that would be better because it more clearly hints that this is the prop-property, not some random property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12184
should be merged after #12201 because it builds on that
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint