Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow let props = $props(), optimize prop read access #12201

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

dummdidumm
Copy link
Member

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

- allow to write `let props = $props()`
- optimize read access of props.x to use `$$props` argument directly; closes #11055
Copy link

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: af4cb5b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

) {
return b.id('$$props');
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this code here instead of inside serialize_get_binding to not bloat that function even further and to not having to adjust the other callsites (AFAIK we only need that logic here)

@trueadm
Copy link
Contributor

trueadm commented Jun 27, 2024

This is also a good opportunity to not allow props.$$events etc

@dummdidumm
Copy link
Member Author

opened #12207 as a follow-up that does that; this PR should be merged first

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-plugge
Copy link

I assume the props are not bindable and there is no way to change that, is that correct?

@dummdidumm
Copy link
Member Author

Yes, you can only use this if you don't have fallback values or bindable props.

@dummdidumm dummdidumm merged commit 33e44ea into main Jun 28, 2024
9 checks passed
@dummdidumm dummdidumm deleted the props-access branch June 28, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5: optimise prop access
3 participants