chore: remove anchor node from each block items #11836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 15af7b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trueadm
changed the title
Rich-Harris
approved these changes
Jun 20, 2024
Rich-Harris
reviewed
Jun 20, 2024
Conduitry
changed the title
FoHoOV
pushed a commit
to FoHoOV/svelte
that referenced
this pull request
Jun 27, 2024
* fix: improve each block runtime heuristics be removing anchor text node * change message * conflict * merge * fix bug * Update .changeset/stale-nails-listen.md --------- Co-authored-by: Rich Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to reduce the DOM complexity of our each blocks. Each entry in the each block gets a text node anchor, which adds significant DOM overhead in all browsers. Removing this gains almost 40-50% performance improvement in some benchmarks when it comes to cleardown impact of big each blocks. Conversely, it also impacts benchmarks too that track this. It turns out that adding lots of text node anchors isn't cheap at all, it's actually quite expensive, so what if we could avoid it entirely?
This PR aims to do that, but I've likely missed some use-cases that we might need to address, even if the test all pass.