-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove tracking parameters from Spiegel.de URLs (#146)
* Add Spiegel Sanitizer Removes all parameters from Spiegel.de URLs, as they use sara tracking parameters, see #139 * Register Spiegel sanitizer in startup * Add Spiegel translation * Create SpiegelSanitizerTest.kt * Rename and move SpiegelSanitizer * Update SpiegelSanitizerTest.kt * Fix linting * Fix linting
- Loading branch information
Showing
4 changed files
with
91 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
...src/main/kotlin/com/svenjacobs/app/leon/core/domain/sanitizer/spiegel/SpiegelSanitizer.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| /* | ||
| * Léon - The URL Cleaner | ||
| * Copyright (C) 2023 Sven Jacobs | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| package com.svenjacobs.app.leon.core.domain.sanitizer.spiegel | ||
|
|
||
| import android.content.Context | ||
| import com.svenjacobs.app.leon.core.common.regex.RegexFactory | ||
| import com.svenjacobs.app.leon.core.domain.R | ||
| import com.svenjacobs.app.leon.core.domain.sanitizer.RegexSanitizer | ||
| import com.svenjacobs.app.leon.core.domain.sanitizer.Sanitizer | ||
| import com.svenjacobs.app.leon.core.domain.sanitizer.SanitizerId | ||
|
|
||
| class SpiegelSanitizer : RegexSanitizer( | ||
| regex = RegexFactory.AllParameters, | ||
| ) { | ||
|
|
||
| override val id = SanitizerId("spiegel") | ||
|
|
||
| override fun getMetadata(context: Context) = Sanitizer.Metadata( | ||
| name = context.getString(R.string.sanitizer_spiegel_name), | ||
| ) | ||
|
|
||
| override fun matchesDomain(input: String) = DOMAIN_REGEX.containsMatchIn( | ||
| input, | ||
| ) | ||
|
|
||
| private companion object { | ||
| private val DOMAIN_REGEX = Regex("spiegel\\.de.+") | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
...test/kotlin/com/svenjacobs/app/leon/core/domain/sanitizer/spiegel/SpiegelSanitizerTest.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| /* | ||
| * Léon - The URL Cleaner | ||
| * Copyright (C) 2023 Sven Jacobs | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| package com.svenjacobs.app.leon.core.domain.sanitizer.spiegel | ||
|
|
||
| import io.kotest.core.spec.style.WordSpec | ||
| import io.kotest.matchers.shouldBe | ||
|
|
||
| class SpiegelSanitizerTest : WordSpec( | ||
| { | ||
|
|
||
| "invoke" should { | ||
|
|
||
| "remove all parameters from Spiegel URL" { | ||
| val sanitizer = SpiegelSanitizer() | ||
| val result = sanitizer( | ||
| "https://www.spiegel.de/netzwelt/elon-musk-twitter-sperrt-konten-mehrerer" + | ||
| "-journalisten-von-new-york-times-washington-post-etc-a-040213a0-aa1e-4" + | ||
| "627-9a5a-69d5f4f929fb?sara_ecid=soci_upd_KsBF0AFjflf0DZCxpPYDCQgO1dEMph1", | ||
| ) | ||
|
|
||
| result shouldBe "https://www.spiegel.de/netzwelt/elon-musk-twitter-sperrt-k" + | ||
| "onten-mehrerer-journalisten-von-new-york-times-washington-post-etc-a-0" + | ||
| "40213a0-aa1e-4627-9a5a-69d5f4f929fb" | ||
| } | ||
| } | ||
| }, | ||
| ) |