Skip to content

Commit

Permalink
[javascript] Remove Buffer usage
Browse files Browse the repository at this point in the history
  • Loading branch information
arjunyel committed Jan 23, 2024
1 parent 805a2f8 commit 6b45d60
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions javascript/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,7 @@ export class Webhook {
}

public verify(
payload: string | Buffer,
payload: string,
headers_:
| WebhookRequiredHeaders
| WebhookUnbrandedRequiredHeaders
Expand Down Expand Up @@ -850,13 +850,9 @@ export class Webhook {
throw new WebhookVerificationError("No matching signature found");
}

public sign(msgId: string, timestamp: Date, payload: string | Buffer): string {
if (typeof payload === "string") {
// Do nothing, already a string
} else if (payload.constructor.name === "Buffer") {
payload = payload.toString();
} else {
throw new Error("Expected payload to be of type string or Buffer. Please refer to https://docs.svix.com/receiving/verifying-payloads/how for more information.");
public sign(msgId: string, timestamp: Date, payload: string): string {
if (typeof payload !== "string") {
throw new Error("Expected payload to be of type string. Please refer to https://docs.svix.com/receiving/verifying-payloads/how for more information.");
}

const encoder = new TextEncoder();
Expand Down

0 comments on commit 6b45d60

Please sign in to comment.