Major waitlist transition fixes - #267
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General flow of things (copied from discord):
Beyond this another route
/events/{event-id}/shutdown-waitlist-schedulerhas been made. It also queues a task for the scheduler to be shutdown from the BAT Worker, as the api has no access to the scheduler.Fixes
See the commit history. The most important ones were switching the logic for shutting down to check for attendee count, not accepted application count. Also, accepted applicants (ie. accepted unconfirmed users) are now waitlisted, instead of all accepted users.
Config changes
This has been documented in apps/api/env.dev.example. however for clarity i will include the new parameters in this pr with defaults:
Known issues