Adjusted phase lines for MadMax progress calculations #1258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. I noticed that in windows MadMax stotik's fork actual phase line ends are different in the logs. And what I see is that they should not include backend_header_lines value (which is not 11 but 15 in my case). This produced wrong percentage calculations in the viewer.
As I mentioned header takes 15 lines and Phase 1 end is actually at line 23. Based on the code this header should be taken into account, but something strange happens with the math, and percentage shows correctly only if I manually substract header lines from each phase ends and put these numbers in the config. So 23-15 = 8 etc.
Also phase weights for MadMax are different than for original plotter, I adjusted weights based on my 4 different 12-20 threads PCs logs.