Correct cycle finding for graphs#2199
Merged
mergify[bot] merged 5 commits intomainfrom Oct 27, 2024
Merged
Conversation
Member
Author
|
@kostmo any thoughts on this? |
kostmo
approved these changes
Oct 26, 2024
Member
kostmo
left a comment
kostmo
left a comment
There was a problem hiding this comment.
Good fix. Surprised there's not some more off-the-shelf solution though.
Member
Author
Well, See here for a related discussion: haskell/containers#978 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2198 . Adds a new function
findCyclefor finding directed cycles in graphs via DFS, and updatesfailOnCyclicGraphto use it rather than SCCs for reporting cycles.