Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow using .swcrc when no option defined #165

Merged
merged 1 commit into from
Jan 20, 2024
Merged

fix: Allow using .swcrc when no option defined #165

merged 1 commit into from
Jan 20, 2024

Conversation

foray1010
Copy link
Contributor

@foray1010 foray1010 commented Nov 4, 2023 •
edited
Loading

I am using jest 29.7.0 (config) and I keep getting error env and jsc.target cannot be used together using this .swcrc. And by digging into the source code I found that the swcTransformOpts is {} in the beginning, thus swcOptions || getOptionsFromSwrc() never works.

@foray1010
Copy link
Contributor Author

@kdy1 Do you think this PR is valid? Do you need a demo repo to reproduce the issue?

kdy1
kdy1 approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think it's a valid change

@kdy1 kdy1 changed the title Fix cannot use .swcrc when no option defined fix: Allow using .swcrc when no option defined Jan 20, 2024
@kdy1 kdy1 merged commit 3e2d31f into swc-project:master Jan 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foray1010 @kdy1