Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(atoms): Rename FastAtom to UnsafeAtom #10070

Merged
merged 2 commits into from
Feb 21, 2025
Merged

refactor(atoms): Rename FastAtom to UnsafeAtom #10070

merged 2 commits into from
Feb 21, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 21, 2025

Description:

UnsafeAtom is a better name, because it's not only fast.

Copy link

changeset-bot bot commented Feb 21, 2025

🦋 Changeset detected

Latest commit: eee826a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 marked this pull request as ready for review February 21, 2025 03:23
@kdy1 kdy1 requested review from a team as code owners February 21, 2025 03:23
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 21, 2025
@kdy1 kdy1 merged commit 1771222 into main Feb 21, 2025
172 checks passed
Copy link
Member Author

kdy1 commented Feb 21, 2025

Merge activity

  • Feb 21, 12:56 PM GMT+9: A user merged this pull request with Graphite.

Copy link

codspeed-hq bot commented Feb 21, 2025

CodSpeed Performance Report

Merging #10070 will degrade performances by 5.31%

Comparing kdy1/unsafe-atom (eee826a) with main (6a90b1f)

Summary

⚡ 1 improvements
❌ 3 regressions
✅ 187 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/jquery 166.7 ms 172.9 ms -3.63%
es/full/minify/libraries/moment 104.7 ms 110.6 ms -5.31%
es/lints/libs/lodash 8.1 ms 8.3 ms -3.24%
es/minifier/libs/jquery 135.6 ms 131.5 ms +3.14%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant