Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/minifier): Prevent double boxing #10074

Open
wants to merge 1 commit into
base: kdy1/changelog-core
Choose a base branch
from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 21, 2025

Description:

VarUsageInfo is already boxed.

Copy link

changeset-bot bot commented Feb 21, 2025

⚠️ No Changeset found

Latest commit: a69d66c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member Author

kdy1 commented Feb 21, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kdy1 kdy1 marked this pull request as ready for review February 21, 2025 04:10
@kdy1 kdy1 requested a review from a team as a code owner February 21, 2025 04:10
@kdy1 kdy1 added this to the Planned milestone Feb 21, 2025
@kdy1 kdy1 force-pushed the kdy1/changelog-core branch from 521aac1 to db5cbbc Compare February 21, 2025 04:53
@kdy1 kdy1 requested review from a team as code owners February 21, 2025 04:53
@kdy1 kdy1 force-pushed the kdy1/changelog-core branch from db5cbbc to e5ea286 Compare February 21, 2025 04:54
Copy link

codspeed-hq bot commented Feb 21, 2025

CodSpeed Performance Report

Merging #10074 will degrade performances by 3.84%

Comparing kdy1/double-box (a69d66c) with kdy1/changelog-core (e5ea286)

Summary

⚡ 3 improvements
❌ 1 regressions
✅ 187 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/jquery 168.3 ms 175 ms -3.84%
es/full/minify/libraries/lodash 192.4 ms 183.3 ms +4.94%
es/minifier/libs/jquery 135.8 ms 131.4 ms +3.41%
es/minifier/libs/moment 84.9 ms 82.2 ms +3.28%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant