Skip to content

Conversation

CodeMan62
Copy link
Contributor

@CodeMan62 CodeMan62 commented Aug 4, 2025

Description:
merges nullish_coalescing into compiler

BREAKING CHANGE:
N/A

Related issue:
This is a par of #10913

@CodeMan62 CodeMan62 requested review from a team as code owners August 4, 2025 17:20
Copy link

changeset-bot bot commented Aug 4, 2025

⚠️ No Changeset found

Latest commit: ad5e6e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codspeed-hq bot commented Aug 4, 2025

CodSpeed Performance Report

Merging #10974 will degrade performances by 2.99%

Comparing CodeMan62:nullish_coalescing/compiler (ad5e6e4) with main (66428a2)

Summary

❌ 1 regression
✅ 139 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es2020_nullish_coalescing 298.6 µs 307.8 µs -2.99%

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix CI and the perf regression?

@CodeMan62 CodeMan62 marked this pull request as draft August 6, 2025 16:17
Copy link

socket-security bot commented Aug 6, 2025

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Critical
[email protected] has a Critical CVE.

CVE: GHSA-fjxv-7rqg-78g4 form-data uses unsafe random function in form-data for choosing boundary (CRITICAL)

Affected versions: < 2.5.4; >= 3.0.0 < 3.0.4; >= 4.0.0 < 4.0.4

Patched version: 2.5.4

From: ?npm/[email protected]

ℹ Read more on: This package | This alert | What is a critical CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
[email protected] has Obfuscated code.

Confidence: 0.96

Location: Package overview

From: ?npm/[email protected]npm/[email protected]

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@CodeMan62 CodeMan62 force-pushed the nullish_coalescing/compiler branch from c41f09b to 7c9b3b7 Compare August 6, 2025 17:42
@CodeMan62
Copy link
Contributor Author

CodeMan62 commented Aug 7, 2025

strange that when running benchmarks locally there is no regression but there is still?

@CodeMan62 CodeMan62 force-pushed the nullish_coalescing/compiler branch from 8039527 to 3a56eca Compare August 14, 2025 06:08
@CodeMan62 CodeMan62 marked this pull request as ready for review September 29, 2025 09:20
Copy link

socket-security bot commented Sep 29, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedcopyfiles@​2.4.110010010078100
Addedwebpack-cli@​3.3.129710010083100
Addedwebpack-dev-server@​3.11.3969310084100
Addedwebpack@​4.47.09710010093100

View full report

@CodeMan62
Copy link
Contributor Author

fixing CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants