Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a new update #104

Closed
wants to merge 2 commits into from
Closed

a new update #104

wants to merge 2 commits into from

Conversation

RandolphTang
Copy link
Collaborator

Author:

What changes were made?

Why are these changes important/necessary?

(If applicable) Screenshots of your changes. Providing an “old vs. new” comparison would be great!

Copy link
Contributor

@elimelt elimelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but there are some things to fix. Also, we need to make sure the mobile view isn't all bad. Probably easiest ATP to use CSS media queries, but if you want to eventually move to a library that would be okay too.


return (
<div>
<Navbar />
<Routes>
<Route index element={<Home />} />
<Route path="/About" element={<About />} />
<Route path="/Officers" element={<Officers />} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path should be lower case

<Route path="/linkedin" element={<ExternalRedirect to="https://www.linkedin.com/company/swecc-uw/" />} />
<Route path="/instagram" element={<ExternalRedirect to="https://www.instagram.com/swecc.uw/" />} />
<Route path="/mailing-list" element={<ExternalRedirect to="http://mailman11.u.washington.edu/mailman/listinfo/sweccmailinglist" />} />
<Route path="/Sponsor" element={<Sponsor />} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path should be lower case

element={
<ExternalRedirect to="http://mailman11.u.washington.edu/mailman/listinfo/sweccmailinglist" />
}
/>
<Route path="/Join-Now" element={<JoinNow />} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path should be lower case

<iframe
title="calendar"
className="calendar"
src="https://calendar.google.com/calendar/embed?src=swecc%40uw.edu&ctz=America%2FLos_Angeles"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment

TODO: switch to updated member calendar

<div className="club-introduction-container">
<h1>Software Engineering Career Club</h1>
<p>at the University of Washington</p>
<a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: file name is inconsistent

</div>
<h2>Why Join Us</h2>
<p>
We are a club with over 1000 members from CS-related departments.{" "}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch copy to

Why join?

Be part of a community of over 1000 people pursuing a career in software engineering

Gain access to resources, including resume reviews, mock interviews, mentorship programs, and more

Expand your network and connect with likeminded students and industry professionals

engineering career with confidence and connections!
<div className="mainPage-body">
<TextLeftImageRight
summary="The Software Engineering Career Club (SWECC) is a student-led
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switch copy to:

The Software Engineering Career Club (SWECC) is a student-led
organization at the University of Washington in Seattle. Our mission
is to support and empower individuals interested in pursuing a
career in software engineering. We offer a wide range of
activities and resources, including networking events, resume reviews, 
mentorship programs, interview preparation, and more. Join us to jumpstart your software engineering career!

"babel-preset-react-app": "^10.0.1",
"cors": "^2.8.5",
"express": "^4.21.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why express and cors?

@@ -6,10 +6,14 @@
"@emotion/react": "^11.11.1",
"@emotion/styled": "^11.11.0",
"@mui/material": "^5.14.8",
"@react-email/components": "^0.0.25",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now can remove this as well as resend

Copy link
Contributor

@elimelt elimelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes

Copy link

github-actions bot commented Nov 7, 2024

Marking as stale since there has been no activity for 30 days. Will close in 7 days if no activity.

@github-actions github-actions bot added the stale label Nov 7, 2024
@github-actions github-actions bot closed this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants