new pr #105

RandolphTang · 2024-09-28T23:35:25Z

Author:

What changes were made?

All officer info is updated

Why are these changes important/necessary?

(If applicable) Screenshots of your changes. Providing an “old vs. new” comparison would be great!

github-actions · 2024-09-28T23:37:03Z

Visit the preview URL for this PR (updated for commit b0543f2):

https://swecc-org--pr105-randolph-0h72fp00.web.app

_{(expires Mon, 14 Oct 2024 01:28:10 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: d5f37faadb442ba8fa7c35b669f11be1475c4891}

elimelt · 2024-09-29T00:48:08Z

src/Components/Home.js

+        <p>
+          Be part of a community of over 1000 people pursuing a career in
+          software engineering. <br />
+          Gain access to resources, including resume reviews, mock interviews,


Don't put breaks; use built in wrapping

elimelt · 2024-09-29T00:49:59Z

src/Data/officers2023.json

+        "email": "[email protected]"
+    },
+    {
+        "name": "Bhavya Linga",


Bhavya no longer with us

elimelt · 2024-09-29T00:50:45Z

src/Data/img/Sponsors/Deloitte.png

I don't think Deloitte is sponsoring us yet :(

elimelt · 2024-09-29T00:54:38Z

src/Components/Sponsor.js

+        <div className="WhySponsor">
+          <h2>Why Sponsor</h2>
+          <p id="HowToSponsorIntro">
+            Sponsoring SWECC to connect with 1,000+ UW CS students. Our <br />


Don't use breaks, and change copy to

"Sponsoring the Software Engineering Career Club gives you access to over 1000 students, >70% of which are part of the Allen School, and >90% in computing related majors. Partner with us to gain access to our resume book, recruiting/promotional events, talent pool, and more.

elimelt · 2024-09-29T00:57:15Z

src/Components/Sponsor.js

+        <div className="HowToSponsor">
+          <h2>How to Sponsor</h2>
+          <p>
+            We appreciate all forms of your supports, you can support us by:


Others have partnered with us by...

Hosting informational/promotional panels

Sponsoring our events, such as hackathons and programming competitions

Getting involved in our professional mentorship program

And much more!

elimelt · 2024-09-29T00:58:13Z

src/Components/Sponsor.js

+        </div>
+
+        <div className="contact-info">
+          <h2 id="contact-info-title">Connect with Us</h2>


I thought we weren't using this? We can set it up with SendGrid now if we want, although idk about preventing the key from getting exposed on here

elimelt · 2024-09-29T00:59:26Z

src/Components/Home.js

+      <div className="posts" ref={scrollContainerRef}>
+        <InstagramEmbed
+          className="instaPost slide-up"
+          url="https://www.instagram.com/p/C7uRAftvEKV/?utm_source=ig_web_copy_link"


can you add the new post? or did you already?

Why are we hardcoding these urls?

ShawnCollinge

Why do we have header.js and nav-bar.js with the same links? I didn't dive too deep into it but something to maybe look into for refactoring.

ShawnCollinge · 2024-10-06T13:39:39Z

package.json

@@ -18,6 +19,7 @@
    "react-scripts": "5.0.1",
    "react-social-media-embed": "^2.3.5",
    "react-transition-group": "^4.4.5",
+    "resend": "^4.0.0",


is this being used anywhere?

ShawnCollinge · 2024-10-06T13:42:42Z

src/Components/App.js

+            <ExternalRedirect to="https://mailman11.u.washington.edu/mailman/listinfo/sweccmailinglist" />
+          }
+        />
+        <Route path="/join-Now" element={<JoinNow />} />


should probably lowercase the N to follow the rest.

ShawnCollinge · 2024-10-06T13:44:19Z

src/Components/Events.js

        )}
      </div>
    </div>
  ));

-  const postId = ["C2-o7roPbfN", "C23PyAWPYdW", "C2boAR4LeRy", "CzVNKp6r9hn", "CzVLbJWLwsI", "Cy4WTIJvVvB", "CyzVzMTJlhQ", "CyRondZPVVS", "CyCms3mLOLb", "Cxum20yOlkQ", "CxrxWcQLpSb"];
+  const postId = [


Is there a reason for hardcoding postIds? Are we not just wanting the most recent n posts? Maybe you can't answer this but maybe @elimelt can?

ShawnCollinge · 2024-10-06T13:45:40Z

src/Components/Header.js

+          <NavLink to="/" className="nav-link">
+            HOME
+          </NavLink>
+          <NavLink to="/Events" className="nav-link">


Does this link work? You lowercased it in the routes.

ShawnCollinge · 2024-10-06T13:45:46Z

src/Components/Header.js

+          <NavLink to="/Events" className="nav-link">
+            EVENTS
+          </NavLink>
+          <NavLink to="/About" className="nav-link">


ShawnCollinge · 2024-10-06T13:49:10Z

src/Components/Home.js

+      <div className="posts" ref={scrollContainerRef}>
+        <InstagramEmbed
+          className="instaPost slide-up"
+          url="https://www.instagram.com/p/C7uRAftvEKV/?utm_source=ig_web_copy_link"


Why are we hardcoding these urls?

ShawnCollinge · 2024-10-06T13:51:54Z

src/Components/Navbar.js

          <NavItem
            icon={<FcConferenceCall />}
-            route={"/About"}
+            route={"/Officers"}


This should also be lowercase.

ShawnCollinge · 2024-10-06T13:52:05Z

src/Components/Navbar.js

            expand={expand}
            closeExpand={closeExpand}
            tooltip="Officers"
            label="Officers"
          />
+          <NavItem
+            icon={<FaHeart />}
+            route={"/Sponsor"}


ShawnCollinge · 2024-10-06T13:52:26Z

src/Components/Navbar.js

@@ -221,7 +195,7 @@ function DropdownMenu(props) {
          <NavLink to="/" onClick={props.closeExpand}>
            <DropdownItem leftIcon={<FcHome />}>Home</DropdownItem>
          </NavLink>
-          <NavLink to="/About" onClick={props.closeExpand}>
+          <NavLink to="/Officers" onClick={props.closeExpand}>


ShawnCollinge · 2024-10-06T13:54:32Z

src/Components/Officers.js

+          <nav className="officer-sidebar">
+            <h2>Year</h2>
+            <ul>
+              {[2024, 2023, 2022, 2021].map((year) => (


Maybe we can not hardcode years, can check if after september then add the next year? Starting with 2021.

ShawnCollinge · 2024-10-06T14:00:28Z

react-email-starter/emails/notion-magic-link.tsx

+
+export default NotionMagicLinkEmail;
+
+const main = {


Why don't we move this css into it's own spot and I think the css can be shared across this and plaid-verify?

ShawnCollinge · 2024-10-07T01:39:39Z

src/Components/Home.js

+  function intPostsWidget() {
+    return (
+      <BeholdWidget
+        onLoad={() => console.log("Loaded!")}


Shouldn't have console.logs in prod please.

RandolphTang and others added 4 commits September 19, 2024 06:11

a new update (everything is updated)

d46bbd0

a new update (everything is updated)

fae4530

new update

6a25b5e

officer info

c4c319e

RandolphTang requested a review from elimelt September 28, 2024 23:35

elimelt requested changes Sep 29, 2024

View reviewed changes

ShawnCollinge reviewed Oct 6, 2024

View reviewed changes

insta auto

b0543f2

wkxdavid assigned RandolphTang Oct 7, 2024

ShawnCollinge reviewed Oct 7, 2024

View reviewed changes

RandolphTang closed this Oct 7, 2024

ShawnCollinge deleted the Randolph branch November 24, 2024 17:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

new pr #105

new pr #105

RandolphTang commented Sep 28, 2024

github-actions bot commented Sep 28, 2024 •

edited

Loading

elimelt Sep 29, 2024

elimelt Sep 29, 2024

elimelt Sep 29, 2024

elimelt Sep 29, 2024

elimelt Sep 29, 2024

elimelt Sep 29, 2024

elimelt Sep 29, 2024

ShawnCollinge Oct 6, 2024

ShawnCollinge left a comment

ShawnCollinge Oct 6, 2024

ShawnCollinge Oct 6, 2024

ShawnCollinge Oct 6, 2024

ShawnCollinge Oct 6, 2024

ShawnCollinge Oct 6, 2024

ShawnCollinge Oct 6, 2024

ShawnCollinge Oct 6, 2024

ShawnCollinge Oct 6, 2024

ShawnCollinge Oct 6, 2024

ShawnCollinge Oct 6, 2024

ShawnCollinge Oct 6, 2024

ShawnCollinge Oct 7, 2024

new pr #105

new pr #105

Conversation

RandolphTang commented Sep 28, 2024

What changes were made?

Why are these changes important/necessary?

(If applicable) Screenshots of your changes. Providing an “old vs. new” comparison would be great!

github-actions bot commented Sep 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShawnCollinge left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Sep 28, 2024 •

edited

Loading