Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow injection of externally initialized ByteBufferAllocator #329

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/AWSLambdaRuntimeCore/Lambda.swift
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ public enum Lambda {
let runtime = LambdaRuntime(
handlerProvider: handlerProvider,
eventLoop: eventLoop,
allocator: ByteBufferAllocator(),
logger: logger,
configuration: configuration
)
Expand Down
4 changes: 2 additions & 2 deletions Sources/AWSLambdaRuntimeCore/LambdaRunner.swift
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ internal final class LambdaRunner {

private var isGettingNextInvocation = false

init(eventLoop: EventLoop, configuration: LambdaConfiguration) {
init(eventLoop: EventLoop, configuration: LambdaConfiguration, allocator: ByteBufferAllocator) {
self.eventLoop = eventLoop
self.runtimeClient = LambdaRuntimeClient(eventLoop: self.eventLoop, configuration: configuration.runtimeEngine)
self.allocator = ByteBufferAllocator()
self.allocator = allocator
}

/// Run the user provided initializer. This *must* only be called once.
Expand Down
19 changes: 18 additions & 1 deletion Sources/AWSLambdaRuntimeCore/LambdaRuntime.swift
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ public final class LambdaRuntime<Handler: LambdaRuntimeHandler> {
private let shutdownPromise: EventLoopPromise<Int>
private let logger: Logger
private let configuration: LambdaConfiguration
private let allocator: ByteBufferAllocator

private let handlerProvider: (LambdaInitializationContext) -> EventLoopFuture<Handler>

Expand All @@ -44,11 +45,13 @@ public final class LambdaRuntime<Handler: LambdaRuntimeHandler> {
convenience init(
handlerProvider: @escaping (LambdaInitializationContext) -> EventLoopFuture<Handler>,
eventLoop: EventLoop,
allocator: ByteBufferAllocator,
logger: Logger
) {
self.init(
handlerProvider: handlerProvider,
eventLoop: eventLoop,
allocator: allocator,
logger: logger,
configuration: .init()
)
Expand All @@ -63,11 +66,13 @@ public final class LambdaRuntime<Handler: LambdaRuntimeHandler> {
init(
handlerProvider: @escaping (LambdaInitializationContext) -> EventLoopFuture<Handler>,
eventLoop: EventLoop,
allocator: ByteBufferAllocator,
logger: Logger,
configuration: LambdaConfiguration
) {
self.eventLoop = eventLoop
self.shutdownPromise = eventLoop.makePromise(of: Int.self)
self.allocator = allocator
self.logger = logger
self.configuration = configuration

Expand Down Expand Up @@ -108,7 +113,7 @@ public final class LambdaRuntime<Handler: LambdaRuntimeHandler> {
var logger = self.logger
logger[metadataKey: "lifecycleId"] = .string(self.configuration.lifecycle.id)
let terminator = LambdaTerminator()
let runner = LambdaRunner(eventLoop: self.eventLoop, configuration: self.configuration)
let runner = LambdaRunner(eventLoop: self.eventLoop, configuration: self.configuration, allocator: self.allocator)

let startupFuture = runner.initialize(handlerProvider: self.handlerProvider, logger: logger, terminator: terminator)
startupFuture.flatMap { handler -> EventLoopFuture<Result<Int, Error>> in
Expand Down Expand Up @@ -232,11 +237,13 @@ public enum LambdaRuntimeFactory {
public static func makeRuntime<Handler: SimpleLambdaHandler>(
_ handlerType: Handler.Type,
eventLoop: any EventLoop,
allocator: ByteBufferAllocator = ByteBufferAllocator(),
logger: Logger
) -> LambdaRuntime<some ByteBufferLambdaHandler> {
LambdaRuntime<CodableSimpleLambdaHandler<Handler>>(
handlerProvider: CodableSimpleLambdaHandler<Handler>.makeHandler(context:),
eventLoop: eventLoop,
allocator: allocator,
logger: logger
)
}
Expand All @@ -251,11 +258,13 @@ public enum LambdaRuntimeFactory {
public static func makeRuntime<Handler: LambdaHandler>(
_ handlerType: Handler.Type,
eventLoop: any EventLoop,
allocator: ByteBufferAllocator = ByteBufferAllocator(),
logger: Logger
) -> LambdaRuntime<some LambdaRuntimeHandler> {
LambdaRuntime<CodableLambdaHandler<Handler>>(
handlerProvider: CodableLambdaHandler<Handler>.makeHandler(context:),
eventLoop: eventLoop,
allocator: allocator,
logger: logger
)
}
Expand All @@ -270,11 +279,13 @@ public enum LambdaRuntimeFactory {
public static func makeRuntime<Handler: EventLoopLambdaHandler>(
_ handlerType: Handler.Type,
eventLoop: any EventLoop,
allocator: ByteBufferAllocator = ByteBufferAllocator(),
logger: Logger
) -> LambdaRuntime<some LambdaRuntimeHandler> {
LambdaRuntime<CodableEventLoopLambdaHandler<Handler>>(
handlerProvider: CodableEventLoopLambdaHandler<Handler>.makeHandler(context:),
eventLoop: eventLoop,
allocator: allocator,
logger: logger
)
}
Expand All @@ -289,11 +300,13 @@ public enum LambdaRuntimeFactory {
public static func makeRuntime<Handler: ByteBufferLambdaHandler>(
_ handlerType: Handler.Type,
eventLoop: any EventLoop,
allocator: ByteBufferAllocator = ByteBufferAllocator(),
logger: Logger
) -> LambdaRuntime<some LambdaRuntimeHandler> {
LambdaRuntime<Handler>(
handlerProvider: Handler.makeHandler(context:),
eventLoop: eventLoop,
allocator: allocator,
logger: logger
)
}
Expand All @@ -308,11 +321,13 @@ public enum LambdaRuntimeFactory {
public static func makeRuntime<Handler: LambdaRuntimeHandler>(
handlerProvider: @escaping (LambdaInitializationContext) -> EventLoopFuture<Handler>,
eventLoop: any EventLoop,
allocator: ByteBufferAllocator = ByteBufferAllocator(),
logger: Logger
) -> LambdaRuntime<Handler> {
LambdaRuntime(
handlerProvider: handlerProvider,
eventLoop: eventLoop,
allocator: allocator,
logger: logger
)
}
Expand All @@ -327,6 +342,7 @@ public enum LambdaRuntimeFactory {
public static func makeRuntime<Handler: LambdaRuntimeHandler>(
handlerProvider: @escaping (LambdaInitializationContext) async throws -> Handler,
eventLoop: any EventLoop,
allocator: ByteBufferAllocator = ByteBufferAllocator(),
logger: Logger
) -> LambdaRuntime<Handler> {
LambdaRuntime(
Expand All @@ -338,6 +354,7 @@ public enum LambdaRuntimeFactory {
return promise.futureResult
},
eventLoop: eventLoop,
allocator: allocator,
logger: logger
)
}
Expand Down
2 changes: 1 addition & 1 deletion Tests/AWSLambdaRuntimeCoreTests/LambdaTest.swift
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ class LambdaTest: XCTestCase {
let task = Task.detached {
print(configuration.description)
logger.info("hello")
let runner = LambdaRunner(eventLoop: eventLoopGroup.next(), configuration: configuration)
let runner = LambdaRunner(eventLoop: eventLoopGroup.next(), configuration: configuration, allocator: ByteBufferAllocator())

try await runner.run(
handler: CodableEventLoopLambdaHandler(
Expand Down
2 changes: 1 addition & 1 deletion Tests/AWSLambdaRuntimeCoreTests/Utils.swift
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func runLambda(
let logger = Logger(label: "TestLogger")
let configuration = LambdaConfiguration(runtimeEngine: .init(requestTimeout: .milliseconds(100)))
let terminator = LambdaTerminator()
let runner = LambdaRunner(eventLoop: eventLoopGroup.next(), configuration: configuration)
let runner = LambdaRunner(eventLoop: eventLoopGroup.next(), configuration: configuration, allocator: ByteBufferAllocator())
let server = try MockLambdaServer(behavior: behavior).start().wait()
defer { XCTAssertNoThrow(try server.stop().wait()) }
try runner.initialize(handlerProvider: handlerProvider, logger: logger, terminator: terminator).flatMap { handler in
Expand Down