Fix Query String Parameters Being Ignored

[emlynmu]

Issue

Query string parameters are dropped

Details

The current implementation of this transport does not work with query string parameters. This is a fairly minimal change that fixes the functionality.

This change adds the query string parameters to the path in the HTTPRequest. Whether or not this is the right place for them can be answered by looking at the code generated by the Swift OpenAPI Generator. An example can be found here.

    func listPets(
        request: HTTPTypes.HTTPRequest,
        body: OpenAPIRuntime.HTTPBody?,
        metadata: OpenAPIRuntime.ServerRequestMetadata
    ) async throws -> (HTTPTypes.HTTPResponse, OpenAPIRuntime.HTTPBody?) {
        try await handle(
            request: request,
            requestBody: body,
            metadata: metadata,
            forOperation: Operations.listPets.id,
            using: {
                APIHandler.listPets($0)
            },
            deserializer: { request, requestBody, metadata in
                let query: Operations.listPets.Input.Query = .init(
                    limit: try converter.getOptionalQueryItemAsURI(
                        in: request.soar_query,
                        style: .form,
                        explode: true,
                        name: "limit",
                        as: Swift.Int32.self
                    ),

The generated code calls request.soar_query from OpenAPIRuntime which extracts the query string from the path in the HTTPRequest. This differs from other path parameters which are extracted from the ServerRequestMetadata.

    func updatePet(
        request: HTTPTypes.HTTPRequest,
        body: OpenAPIRuntime.HTTPBody?,
        metadata: OpenAPIRuntime.ServerRequestMetadata
    ) async throws -> (HTTPTypes.HTTPResponse, OpenAPIRuntime.HTTPBody?) {
        try await handle(
            request: request,
            requestBody: body,
            metadata: metadata,
            forOperation: Operations.updatePet.id,
            using: {
                APIHandler.updatePet($0)
            },
            deserializer: { request, requestBody, metadata in
                let path: Operations.updatePet.Input.Path = .init(petId: try converter.getPathParameterAsURI(
                    in: metadata.pathParameters,
                    name: "petId",
                    as: Swift.Int64.self
                ))

Testing

I have also added updated the tests to verify that the routing is not broken by this change. I noticed you recently changed the tests to use the Swift Testing framework. The modification I made uses the arguments feature to try multiple values, but further refactoring of this type is also possible. There wasn't an existing setup with mocks to test the query string being passed all the way through but that would be another improvement possible. I have confirmed that the query string parameters do come through now end-to-end when used in a project.

[emlynmu]

@sebsto let me know if you have any feedback on this or want changes. I know I just opened it out of the blue, but I've been using this Swift package and this is an issue I was facing. The issue is that the current release completely ignores query string parameters so it seems high priority to me. I can also provide additional details demonstrating the issue if you would like me to. I didn't want to put a tremendous amount of work into this until I got confirmation that it was OK, but I'm happy to put additional effort in if it's going to be used.

[sebsto]

Thank you @emlynmu for this PR.
I overlooked this use case - apologies for that