Do not try to merge branches in create_automerge_pr
#113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a merge commit here was pointless and caused the job to fail if there was a merge conflict. Instead, we should check if there are any commits that need to be merged and if so, create a new branch that just fixes the head branch to open a PR. If there are any merge conflicts, they will now be shown in the PR.
shahmishal
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a merge commit here was pointless and caused the job to fail if there was a merge conflict. Instead, we should check if there are any commits that need to be merged and if so, create a new branch that just fixes the head branch to open a PR.
If there are any merge conflicts, they will now be shown in the PR.