Skip to content

Update license_header_check_project_name to no longer be required #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahmishal merged 2 commits into from
Feb 28, 2025
Merged

Update license_header_check_project_name to no longer be required #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17aa86b
Fixed an issue where a PROJECT_NAME was required even though a templa…
dimitribouniol Feb 1, 2025
2ad4ac1
Updated `license_header_check_project_name` to no longer be required
dimitribouniol Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/scripts/check-license-header.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,11 @@ log() { printf -- "** %s\n" "$*" >&2; }
error() { printf -- "** ERROR: %s\n" "$*" >&2; }
fatal() { error "$@"; exit 1; }

test -n "${PROJECT_NAME:-}" || fatal "PROJECT_NAME unset"

if [ -f .license_header_template ]; then
# allow projects to override the license header template
expected_file_header_template=$(cat .license_header_template)
else
test -n "${PROJECT_NAME:-}" || fatal "PROJECT_NAME unset"
expected_file_header_template="@@===----------------------------------------------------------------------===@@
@@
@@ This source file is part of the ${PROJECT_NAME} open source project
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/soundness.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ on:
default: true
license_header_check_project_name:
type: string
description: "Name of the project called out in the license header."
required: true
description: "Name of the project called out in the license header. Required unless `license_header_check_enabled` is false or a `.license_header_template` file is present."
default: ""
broken_symlink_check_enabled:
type: boolean
description: "Boolean to enable the broken symlink check job. Defaults to true."
Expand Down