-
Notifications
You must be signed in to change notification settings - Fork 332
Add parameterLabel modifier for argument labels in semantic tokens #2395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add parameterLabel modifier for argument labels in semantic tokens #2395
Conversation
02d3446 to
80f905b
Compare
ahoppen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Looks good to me, I’d just like to define the modifier in swift-tools-protocols.
Sources/SourceKitLSP/SemanticTokensLegend+SourceKitLSPLegend.swift
Outdated
Show resolved
Hide resolved
|
@ahoppen i have a open pr on swift-tools-protocols for this. we will have to merge that first. swiftlang/swift-tools-protocols#31 before this |
80f905b to
682bac6
Compare
|
Thanks for the PR to swift-tools-protocols. We will need @owenv’s help to tag a new release of swift-tools-protocols and get it into the CI pipeline and he’s on vacation until the new year. Let’s get this over the finish line when he’s back. |
|
@owenv is already on it. https://github.com/swiftlang/swift-tools-protocols/releases/tag/0.0.10 has just been tagged and we now need to update the toolchain builds to use that tag so we can land this PR. |
|
@ahoppen so do i have to open a separate pr to bump swift-tools-protocols to 0.0.10 in package.swift? i noticed its one of the only ones that is tagged to a version and not directly to main |
|
We have #2425 for that. We also need to bump the version in other repos at the same time plus some additional manual work in CI jobs. I’ll let you know once the version has been updated and we can proceed with this PR. Sorry for the delay. |
|
Thanks for the update, appreciate you handling the coordination. I’m not in a rush, happy to wait until the version bumps land. |
Motivation: Argument labels are currently tokenized as function without any modifier, making them indistinguishable from function names. This prevents theme authors from styling them differently, particularly important for accessibility (e.g., themes for neurodivergent developers) and personal preference.
Changes:
Fixes #1540