map semantic refactoring kinds to specific LSP code action kinds #2421
+18
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #2382
Maps SourceKit semantic refactoring action strings to specific LSP
CodeActionKindvalues instead of using the genericrefactorkind. This enables standard refactoring keybindings and code action filtering to work properly for Swift.Images After The Change
Changes
lspKindcomputed property toSemanticRefactorCommandthat maps:.extract.→refactor.extract.inline.→refactor.inlinerefactor(fallback)retrieveRefactorCodeActionsto use the newlspKindproperty