add weather app example #25
Merged
+1,788
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
swiftlang/swift-java#483 was merged 👍 |
Collaborator
|
LGTM, although I had trouble with the emulator and location permissions. This is a great example though, let's include it |
Member
|
I'll take a look and then we can get this in. |
ktoso
approved these changes
Dec 18, 2025
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Lgtm, I’ve run the example and it’s very nice
finagolfin
approved these changes
Dec 18, 2025
Member
finagolfin
left a comment
finagolfin
left a comment
There was a problem hiding this comment.
Couple small nits, @madsodgaard, and we can get this in.
hello-swift-java/hashing-app/src/main/java/com/example/hashingapp/MainActivity.kt
Outdated
Show resolved
Hide resolved
Member
|
Oh, add some info and a link in the top-level README also. |
finagolfin
reviewed
Dec 18, 2025
Member
|
Thanks for adding this, Mads. 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new example that demonstrates calling
asyncfunctions and implementing Swiftprotocolsin Java.This requires swiftlang/swift-java#483 to be merged.