- 
                Notifications
    You must be signed in to change notification settings 
- Fork 118
add new spoiler extension #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gfm
Are you sure you want to change the base?
Conversation
| I'm working on updating this PR. It turns out that there are multiple implementations of spoiler text. The one i implemented was based on Discord's markup. However, Reddit uses a completely different set of delimiters, and formats its spoiler text  In addition, at the same time i'm fixing some of the testing scripts to adjust to the different directory layout of this fork and update some Python conventions, since i hadn't tried executing them at that time. This is allowing me to properly run all the original CommonMark and GFM regression and specification tests, which is turning out to be very helpful. | 
89c19cb    to
    dce9a9b      
    Compare
  
    | I've updated the PR to add the option to parse Reddit-style spoiler delimiters instead of Discord-style delimiters. This involved pulling in work from upstream (#29) and fixing some unrelated issues (#30), which means that this PR now depends on those other ones. I've updated the base branch accordingly. | 
dce9a9b    to
    71a79e4      
    Compare
  
    46bda92    to
    05a5f22      
    Compare
  
    d9b0520    to
    76ae837      
    Compare
  
    
This PR adds a variant of the
strikethroughextension to create a newspoilerextension, for creating "spoiler" text. Since hiding text is a matter of styling it in the client, this extension just renders HTML as a<span class="spoiler">tag.