Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clang source module support #56

Closed

Conversation

Kyle-Ye
Copy link
Contributor

@Kyle-Ye Kyle-Ye commented Apr 23, 2023

Bug/issue #, if applicable:

Summary

https://github.com/Kyle-Ye/swift-docc-plugin-mix-demo#swift-doc-for-objetivec-module

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran the ./bin/test script and it succeeded
  • Updated documentation if necessary

@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Jul 17, 2023

@ethan-kusters Could you add the PR link you mentioned on the Swift Documentation Workgroup meeting? Thanks

@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Jul 17, 2023

It works fine to generate Swift symbol-graph for a clang target using the existing SwiftPM API.

Download the following code example and run swift package --disable-sandbox preview-documentation --target CKit
CKit.zip

image

@d-ronnqvist
Copy link
Contributor

IIUC this functionality is implemented by #95 instead.

@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Sep 5, 2024

IIUC this functionality is implemented by #95 instead.

Thanks for getting this issue resolved! I noticed that my earlier PR addressed a similar fix but hasn't received much attention for a while. I'm curious if there might be any internal processes or factors that influenced the prioritization of this one. Does being an Apple employee play any role in the review process?

Looking forward to understanding more about how things work. Thanks again!

@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Sep 5, 2024

Also noticed the main difference between #95 and this one is some wording change (e.g change "is not a Swift module" to "is not a Swift/Clang module") and the addition of "any" for the existential module instance.

Curious if these changes warranted a new PR.

Would appreciate any insights. Thanks again!

@Kyle-Ye Kyle-Ye closed this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants