Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close mobile navigator, when clicking on any navigation item #364

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dobromir-hristov
Copy link
Contributor

Bug/issue #, if applicable: 90839759

Summary

Closes the mobile navigator, if clicked on the already highlighted current page, even though no page navigation is performed.

Dependencies

NA

Testing

Steps:

  1. Go to a page in the navigator
  2. While in mobile screen size open the navigator again and click on the current (bolded) page link again
  3. Assert the navigator is hidden but nothing else happens.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

@marinaaisa marinaaisa self-requested a review July 6, 2023 17:43
Copy link
Member

@marinaaisa marinaaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved it before but afterwards I realised that it's affecting the desktop experience as well . It should only affect mobile users. Thanks and sorry for the confusion!

src/components/Navigator/NavigatorCard.vue Outdated Show resolved Hide resolved
…clicking-current-page

# Conflicts:
#	tests/unit/components/Navigator/NavigatorCard.spec.js
@dobromir-hristov
Copy link
Contributor Author

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants