Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AX] Prevented from adding #main anchor into the URL when skipping navigation #710

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marinaaisa
Copy link
Member

@marinaaisa marinaaisa commented Jul 5, 2023

Bug/issue #109460523, if applicable:

Summary

Skip navigation only works once on a page. Because when we trigger the skip, we insert the #main anchor in the URL of the current page. Then, when we try to skip again, it does not work properly.

To fix this issue, I prevented it from adding main anchor into the URL.

Dependencies

NA

Testing

Steps:

  1. Go to any page
  2. Start tabbing and you will see "Skip navigation" text
  3. Assert that when you click on it, it focuses the main element and then you can continue tabbing from there. But it doesn't add "#main" into the URL

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

@marinaaisa
Copy link
Member Author

@swift-ci test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants