Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete card hover effect in small viewports #820

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marinaaisa
Copy link
Member

Bug/issue #127050375, if applicable:

Summary

Delete card hover effect in small viewports. Hover effects in small viewports are only triggered when the link is active and we don't need this effect for active states.

Dependencies

NA

Testing

Steps:

  1. Run a .doccarchive that has Cards on it
  2. Use a small viewport
  3. Click in the Card
  4. Assert that there is no effect in its active state

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

@hqhhuang
Copy link
Contributor

hqhhuang commented May 6, 2024

I personally think we should keep the hover effect consistent across viewports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants