Fail Macro Expansion if JavaStaticField is used in non-class#174
Merged
ktoso merged 4 commits intoswiftlang:mainfrom Nov 15, 2024
Merged
Fail Macro Expansion if JavaStaticField is used in non-class#174ktoso merged 4 commits intoswiftlang:mainfrom
ktoso merged 4 commits intoswiftlang:mainfrom
Conversation
ktoso
reviewed
Nov 10, 2024
ktoso
reviewed
Nov 10, 2024
ktoso
reviewed
Nov 10, 2024
Collaborator
ktoso
left a comment
There was a problem hiding this comment.
looks good, minor comment
ktoso
approved these changes
Nov 10, 2024
Collaborator
|
Tests failed, something isn't quite right: |
Contributor
Author
Oh my. I'm checking for classdecl, but I think I need to check for extensiondecl. I'll fix this up soon |
ktoso
approved these changes
Nov 15, 2024
Collaborator
ktoso
left a comment
There was a problem hiding this comment.
Nice, thank you very much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65
This adds support for failing macro expansion if
JavaStaticFieldis used in the incorrect context.One thing I was thinking is we can add similar logic for the
JavaStaticMethodto fail in that context. That will fail in compilation, but it could be nicer to fail expansion vs fail in an implementation detail (of a function not existing on the type)