Use thread environment instead for JNI methods #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
approved these changes
Nov 29, 2025
Collaborator
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Seems reasonable, got any test that failed before and will now work to add here tho?
Contributor
Author
|
@ktoso I added a simple test |
Collaborator
|
Neat, lgtm! |
ktoso
approved these changes
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, interacting with any
AnyJavaObjectis only possible from the thread that created it. This is quite limiting, as its often needed to pass these objects across threads. This limitation also affects features like the protocol bridging, as we use wrap-Java to callback to Java from Swift, and they will cross threads.The reason this is, is that currently all the method call helpers use the
javaEnvironmentfromJavaObjectHolder, which is the environment that was used when the object was created. I don't see a reason why we should use this environment to interact with the object, after its creation. We should really be using the current threads environment instead, otherwise the JVM will crash.This PR also fixes #157