Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable development mode #8139

Open
wants to merge 1 commit into
base: release/6.1
Choose a base branch
from
Open

Disable development mode #8139

wants to merge 1 commit into from

Conversation

bkhouri
Copy link
Contributor

@bkhouri bkhouri commented Nov 25, 2024 •
edited
Loading

Disable development mode in the release 6.1 branch.

Motivation:

We should never release Swift Package Manager in development mode. So this disables dev mode and brings in the functionality of 999.0 over being introduced specific swift tool version (primarily in tests)

Modifications:

Modify SwiftVersion isDevelopment to false and update references to swift tool version 999.0 to a specific version.

Result:

swift test

@dschaefer2
Copy link
Member

This will not get approved until we are out of development phase or the Traits proposal gets approved. It is correctly marked 999.0 since it's a development only feature of the manifest.

@bkhouri bkhouri changed the title T/release6.1/disable dev mode Disable development mode Nov 25, 2024
@bkhouri
Copy link
Contributor Author

bkhouri commented Nov 25, 2024

Understood. Once we are out of development phase, and if the Traits proposal has not been approved yet, we can revert those changes and adjust accordingly.

@bkhouri bkhouri changed the base branch from main to release/6.1 December 11, 2024 20:06
@bkhouri bkhouri force-pushed the t/release6.1/disable_dev_mode branch 2 times, most recently from df93234 to 336b52f Compare December 13, 2024 20:46
@bkhouri
Copy link
Contributor Author

bkhouri commented Dec 13, 2024

@swift-ci please test

@bkhouri bkhouri marked this pull request as ready for review December 13, 2024 21:23
@dschaefer2
Copy link
Member

I think it makes sense to wait for the auto merger to be turned off before doing this in case we have some traits work to push in that will conflict with this. Not sure it's likely but we are also not technically out of developer mode until then either.

@bkhouri
Copy link
Contributor Author

bkhouri commented Dec 13, 2024

I think it makes sense to wait for the auto merger to be turned off before doing this in case we have some traits work to push in that will conflict with this. Not sure it's likely but we are also not technically out of developer mode until then either.

Just getting the PR ready to merge whenever we are ready to merge this

@bkhouri bkhouri force-pushed the t/release6.1/disable_dev_mode branch from 336b52f to 0656a1c Compare December 17, 2024 13:31
@bkhouri bkhouri mentioned this pull request Dec 20, 2024
Merged
bkhouri added a commit that referenced this pull request Dec 20, 2024
@bkhouri
Tool version updates (#8183)
307316d 
Update the `ToolsVersion` data structure to include the 6.1.0 release,
and update some references to ToolsVersion.vNext and 999.0 to
non-development releases.


References:
- #8139
- #8074
@bkhouri bkhouri force-pushed the t/release6.1/disable_dev_mode branch from 0656a1c to 59177a4 Compare December 20, 2024 21:11
@bkhouri
Disable development mode
2d6358f 
Disable development mode on the release.
@bkhouri bkhouri force-pushed the t/release6.1/disable_dev_mode branch from 59177a4 to 2d6358f Compare December 20, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranzBusch FranzBusch Awaiting requested review from FranzBusch

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov MaxDesiatov is a code owner

@jakepetroules jakepetroules Awaiting requested review from jakepetroules jakepetroules is a code owner

@francescomikulis francescomikulis Awaiting requested review from francescomikulis francescomikulis is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@dschaefer2 dschaefer2 Awaiting requested review from dschaefer2 dschaefer2 is a code owner

@shawnhyam shawnhyam Awaiting requested review from shawnhyam shawnhyam is a code owner

@bripeticca bripeticca Awaiting requested review from bripeticca bripeticca is a code owner

@plemarquand plemarquand Awaiting requested review from plemarquand plemarquand is a code owner

@owenv owenv Awaiting requested review from owenv owenv is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkhouri @dschaefer2