Unify swift-bootstrap with swift-build and swift-test

[MaxDesiatov]

Motivation:

Existing code in swift-bootstrap mostly follows swift-build/swift-test in an ad-hoc manner, but somewhat deviates from that swift-test such that environmental builds are not possible with the current setup. Let's unify this code to avoid the divergence and make maintenance easier.

This is a prerequisite for enabling incremental builds when running ./Utillities/bootstrap build --release and ./Utilities/bootstrap test --release in sequence.

Modifications:

1. Moved required APIs like AsyncSwiftCommand extensions from Commands to CoreCommands.
2. Added a dependency on CoreCommands to swift-bootstrap.
3. Converted swift-bootstrap from top-level code to @main.
4. Renamed SwiftBoostrapBuildTool to SwiftBootstrapCommand for consistency with other commands.
5. Added AsyncSwiftCommand conformance to SwiftBootstrapCommand.
6. Added a trivial but sufficient func run(_: SwiftCommandState) implementation to SwiftBootstrapCommand.
7. Removed old code that became unused.

Result:

Made swift-bootstrap behavior more consistent and predictable, ~450 LoC removed.

[MaxDesiatov]

@swift-ci test

[MaxDesiatov]

@swift-ci test

[MaxDesiatov]

@swift-ci test

[MaxDesiatov]

@swift-ci test linux

[MaxDesiatov]

@swift-ci test

[MaxDesiatov]

@swift-ci test

[dschaefer2]

Mind you, I find the title funny. swift-build and swift-test aren't necessary consistent with each other. But that's a separate issue :).

[MaxDesiatov]

Certainly more consistent with each other WRT incremental builds than either of them is with swift-bootstrap.

[neonichu]

Note that the point of swift-bootstrap was to only require a minimal set of modules and dependencies for bootstrapping. It will transitively depend on Workspace (i.e. "everything") with this change, so I'd recommend to just use swift-build for bootstrapping at that point.

[dschaefer2]

Note that the point of swift-bootstrap was to only require a minimal set of modules and dependencies for bootstrapping. It will transitively depend on Workspace (i.e. "everything") with this change, so I'd recommend to just use swift-build for bootstrapping at that point.

Yeah, I guess I've haven't quite figured out what the bootstrap was supposed to be for. If it's doing a build, wouldn't you need the Workspace, and then yeah, why not just use swift-build?

[MaxDesiatov]

If it's doing a build, wouldn't you need the Workspace

You wouldn't, a build system can be created without a Workspace.

and then yeah, why not just use swift-build?

swift build pulls in too much stuff, like package registries code and swift-crypto, which causes the current build issues on CI. Those are apparently due to wrong BoringSSL or swift-crypto libraries, maybe coming from the host instead of freshly built ones, IDK.

I'm going to refactor the PR to allow using SwiftCommandState (or a subset of it) without needing a Workspace, but still preserve the rest of swift-build logic and SwiftCommandState logic of build parameters preparation, which is apparently what breaks incremental builds in the first place.