Tests: Convert Basics/FileSystem/* to Swift Testing #8448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci test self hosted windows |
bkhouri
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
cmcgee1024 and
daveyc123
as code owners
|
Recreating part of #8093 |
bkhouri
force-pushed
the
t/main/convert_pathtests_to_swift_testing
branch
from
f77a6f1 to
304833a
Compare
|
@swift-ci test |
|
@swift-ci test self hosted windows |
|
@swift-ci test windows |
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 4, 2025
Update the Basics/FileSystem/*.swift test to enable more tests that pass on Windows - Update function name to get a sense of which tests are passing on Windows Fixes: swiftlang#8433 Issue: rdar://148248105 Depends on: swiftlang#8448
bkhouri
force-pushed
the
t/main/convert_pathtests_to_swift_testing
branch
from
304833a to
c7673b6
Compare
|
@swift-ci please test |
|
@swift-ci test self hosted windows |
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 4, 2025
Update the Basics/FileSystem/*.swift test to enable more tests that pass on Windows - Update function name to get a sense of which tests are passing on Windows Fixes: swiftlang#8433 Issue: rdar://148248105 Depends on: swiftlang#8448
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 4, 2025
Update the Basics/FileSystem/*.swift test to enable more tests that pass on Windows - Update function name to get a sense of which tests are passing on Windows Depends on: swiftlang#8448 Partially Addresses: swiftlang#8433 Issue: rdar://148248105
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 4, 2025
Enable more tests on Windows that are currently passing in Basics/FileSystem/*.swift Depends on: swiftlang#8448 Partially Addresses: swiftlang#8433 Issue: rdar://148248105
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 4, 2025
Enable more tests on Windows that are currently passing in Basics/FileSystem/*.swift Depends on: swiftlang#8448 Partially Addresses: swiftlang#8433 Issue: rdar://148248105
pmattos
reviewed
Apr 5, 2025
| import class Foundation.ProcessInfo | ||
| import Testing | ||
|
|
||
| extension Trait where Self == Testing.ConditionTrait { |
There was a problem hiding this comment.
Given Testing.ConditionTrait conforms to Trait, can't we simply write this instead?
extension Testing.ConditionTrait {There was a problem hiding this comment.
This file was a direct copy from IntegartionTests/Sources/IntegrationTests. I want to avoid changing it drastically until #8223 is completed
jakepetroules
approved these changes
Apr 8, 2025
Until $8223 is fixed copy some helpers from `IntergrationTests/Source/IntegrationTests`` to `Test/_InternalTestSupport` so we can re-use the functionality. Related to: swiftlang#8433 rdar://148248105
Convert test from XCTest to Swift Testing. - Tests/BasicsTests/FileSystem/FileSystemTests.swift - Tests/BasicsTests/FileSystem/PathShimTests.swift - Tests/BasicsTests/FileSystem/PathTests.swift - Tests/BasicsTests/FileSystem/TemporaryFileTests.swift - Tests/BasicsTests/FileSystem/VFSTests.swift relates to: swiftlang#8433
bkhouri
force-pushed
the
t/main/convert_pathtests_to_swift_testing
branch
from
c7673b6 to
a07e0b1
Compare
bkhouri
added a commit
to bkhouri/swift-package-manager
that referenced
this pull request
Apr 8, 2025
Enable more tests on Windows that are currently passing in Basics/FileSystem/*.swift Depends on: swiftlang#8448 Partially Addresses: swiftlang#8433 Issue: rdar://148248105
|
@swift-ci test |
|
@swift-ci test self hosted windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert test from XCTest to Swift Testing.
relates to: #8433
depends on #8467